Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments API - How can author.iconPath reference a file bundled with the extension? #174690

Closed
gjsjohnmurray opened this issue Feb 17, 2023 · 2 comments · Fixed by #175361
Closed

Comments API - How can author.iconPath reference a file bundled with the extension? #174690

gjsjohnmurray opened this issue Feb 17, 2023 · 2 comments · Fixed by #175361
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
March 2023

Comments

@gjsjohnmurray
Copy link
Contributor

At https://github.com/gjsjohnmurray/vscode-extension-samples/tree/show-iconpath I have created a branch in which the comment-sample example has been amended to set the author property of the comments it adds.

Here are the lines that create the author object:

https://github.com/gjsjohnmurray/vscode-extension-samples/blob/e0da92cfdf830988616b7f5f2a905ae0054fa4f4/comment-sample/src/extension.ts#L23-L27

image

The commented-out one was my original, but when running on Desktop the console of devtools reported that the file: resource wasn't allowed. After digging through sources I found how to make it work on that platform by using the vscode-file scheme.

But this doesn't work when running on Codespaces.

What must I set iconPath to so the icon appears when running on that platform too?

Version: 1.76.0-insider
Commit: dc619de
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/110.0
Embedder: codespaces
@gjsjohnmurray
Copy link
Contributor Author

/assign @alexr00

gjsjohnmurray added a commit to gjsjohnmurray/vscode that referenced this issue Feb 18, 2023
@gjsjohnmurray
Handle file uri in CommentAuthorInformation.iconPath (fix microsoft#1…
d7e707b 
…74690)
@gjsjohnmurray gjsjohnmurray mentioned this issue Feb 18, 2023
Closed
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues labels Feb 24, 2023
@alexr00 alexr00 added this to the March 2023 milestone Feb 24, 2023
@alexr00
Copy link
Member

alexr00 commented Feb 24, 2023

Thanks for finding this! Full details on the bug are in #174751 (comment).

gjsjohnmurray added a commit to gjsjohnmurray/vscode that referenced this issue Feb 24, 2023
@gjsjohnmurray
Handle file uri in CommentAuthorInformation.iconPath (fix microsoft#1…
1db9aa6 
…74690)
@gjsjohnmurray gjsjohnmurray mentioned this issue Feb 24, 2023
Merged
alexr00 pushed a commit that referenced this issue Mar 20, 2023
@gjsjohnmurray
Handle file uri in CommentAuthorInformation.iconPath (fix #174690) (#…
14e7b24 
…175361)
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 20, 2023
@connor4312 connor4312 added the verified Verification succeeded label Mar 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
March 2023
4 participants
@connor4312 @gjsjohnmurray @alexr00 @vscodenpa