Skip to content
This repository was archived by the owner on Oct 1, 2024. It is now read-only.

Fix IntelliSense configuration for Arduino CLI #1591

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

benmcmorran
Copy link
Member

Fixes a few issues when using Arduino CLI:

  • Arduino CLI seems to always use LF newlines regardless of the operating system. We were looking for CRLF on Windows (Arduino IDE behavior) which meant the compile output parser never got any data.
  • The Arduino CLI process can exit before all the output data has been received on stdout by VS Code. The data arrives quickly but we need to use the close event on the child process to be sure we don't start parsing until the streams are closed.
  • (cosmetic) By default, Arduino CLI uses terminal escape sequences to color certain parts of the output. These look ugly in VS Code's output window, which is not a terminal emulator. Pass the --no-color option to leave them out, at least for compile. We likely need to pass this flag in other places as well, but I'm planning to leave that for a more significant refactor when support for Arduino IDE is dropped.

@benmcmorran benmcmorran force-pushed the dev/bemcmorr/arduino-cli-intellisense branch from df5b367 to c0b6f47 Compare February 14, 2023 23:32
@benmcmorran benmcmorran merged commit 9a95532 into main Feb 15, 2023
@benmcmorran benmcmorran deleted the dev/bemcmorr/arduino-cli-intellisense branch February 15, 2023 17:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants