Revert didOpen changes in favor of adding encoding to didChangeVisibleTextEditors #13802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-mcmanus
approved these changes
Aug 1, 2025
sean-mcmanus
added a commit
that referenced
this pull request
Aug 7, 2025
* Fix the description of debugServerPath (#13778) This mentions the non-existent miDebugServerAddress, but the correct name is actually miDebuggerServerAddress. * Enable string length encoding fix in cpptools (#13769) * Try to fix the Windows builds. (#13788) * Update IntelliSense loc strings. (#13793) * Makes remote attach picker respect the pipeTransport.quoteArgs config… (#13794) * Makes remote attach picker respect the pipeTransport.quoteArgs configuration * fixes linter error - don't compare boolean value to a boolean * Remove "exceptions" from quoteArgs. (#13796) * Fix loc for the miDebuggerServerAddress change. (#13797) * Update changelog for 1.27.0 (2nd time). (#13795) * Update changelog for 1.27.0 (2nd time). * Update form-data. (#13800) * Update form-data. * Revert didOpen changes in favor of adding encoding to didChangeVisibleTextEditors (#13802) * fixing formatting (#13810) * Enable CG trigger on insiders branch * Handle .txx/tpp headers. (#13811) * Handle .txx headers. * Add tpp too. * fix #13818 (#13824) * Bump tmp from 0.2.3 to 0.2.4 in /Extension (#13825) Bumps [tmp](https://github.com/raszi/node-tmp) from 0.2.3 to 0.2.4. - [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md) - [Commits](raszi/node-tmp@v0.2.3...v0.2.4) --- updated-dependencies: - dependency-name: tmp dependency-version: 0.2.4 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sean McManus <seanmcm@microsoft.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Joshua Goins <josh@redstrate.com> Co-authored-by: Colen Garoutte-Carson <49173979+Colengms@users.noreply.github.com> Co-authored-by: Matt <59707001+mjrist@users.noreply.github.com> Co-authored-by: Bob Brown <bobbrow@users.noreply.github.com> Co-authored-by: Luca <681992+lukka@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue related to:
#13769
... where the change to didOpen resulted in race conditions between the new didOpen message and other messages.
This change restores the original didOpen and instead piggy-backs the encoding on the didChangeVisibleTextEditors message (which must be received before we start language services for a file).
There is also a native-side PR.