Skip to content

Change the command used to install pip on AppVeyor to avoid installation errors #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2018
Merged

Change the command used to install pip on AppVeyor to avoid installation errors #1108

merged 1 commit into from
Mar 18, 2018

Conversation

DonJayamanne
Copy link

Fixes #1107

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov
Copy link

codecov bot commented Mar 17, 2018 •
edited
Loading

Codecov Report

Merging #1108 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1108      +/-   ##
==========================================
+ Coverage   71.75%   71.81%   +0.06%     
==========================================
  Files         260      260              
  Lines       11887    11887              
  Branches     2106     2106              
==========================================
+ Hits         8529     8537       +8     
+ Misses       3230     3226       -4     
+ Partials      128      124       -4
Impacted Files Coverage Δ
...rc/client/debugger/PythonProcessCallbackHandler.ts 52.96% <0%> (-0.66%) ⬇️
src/client/debugger/Main.ts 50% <0%> (+0.48%) ⬆️
src/client/debugger/PythonProcess.ts 48.75% <0%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 660508d...cffc110. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 2823f09 into microsoft:master Mar 18, 2018
@brettcannon
Copy link
Member

FYI you should always just use python -m pip and not the pip command. It not only is xplat but it also disambiguates which Python interpreter you're about to affect.

@DonJayamanne DonJayamanne deleted the issue1107 branch March 19, 2018 22:16
ankostis added a commit to ankostis/traitlets that referenced this pull request Mar 21, 2018
@ankostis
chore(appveyor): fix pip install -U suddenly failing
63e95e1 
See microsoft/vscode-python#1108
@ankostis ankostis mentioned this pull request Mar 21, 2018
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikhailArkhipov MikhailArkhipov MikhailArkhipov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix appveyor tests due to pip installation failure
3 participants
@DonJayamanne @brettcannon @MikhailArkhipov