Fixes to comparing of Python environments #23417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
May 13, 2024
| @@ -276,14 +276,20 @@ export function areSameEnv( | |||
| if (leftInfo === undefined || rightInfo === undefined) { | |||
| return undefined; | |||
| } | |||
| const leftFilename = leftInfo.executable!.filename; | |||
There was a problem hiding this comment.
Use of the bang ! here is wrong, compiler says it can be undefined, but we're ignoring that.
And we run into issues as a result.
anthonykim1
pushed a commit
to anthonykim1/vscode-python
that referenced
this pull request
May 16, 2024
DonJayamanne
added a commit
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.