Do not truncate whitespace for multi-line string #23977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
approved these changes
Aug 20, 2024
|
Does this break sending the code to the python terminal with shfit+enter when there are doc strings in the function because it sends the function in 2 different lines? |
|
@anthonykim1 good case for a unit test regardless of whether it breaks that case or not 👆 |
This was referenced Sep 11, 2024
anthonykim1
added a commit
that referenced
this pull request
Sep 11, 2024
This reverts commit e751377.
anthonykim1
added a commit
that referenced
this pull request
Sep 11, 2024
anthonykim1
added a commit
to anthonykim1/vscode-python
that referenced
this pull request
Sep 11, 2024
…24096) Reverts microsoft#23977 Have to revert microsoft#23977 with issue: microsoft#23743 due to microsoft#24069 Will revisit why microsoft#23743 is breaking if contained inside other top level (in ast term) code block, and look into how to support microsoft#23743 without breaking.
anthonykim1
added a commit
to anthonykim1/vscode-python
that referenced
this pull request
Sep 12, 2024
…24096) Reverts microsoft#23977 Have to revert microsoft#23977 with issue: microsoft#23743 due to microsoft#24069 Will revisit why microsoft#23743 is breaking if contained inside other top level (in ast term) code block, and look into how to support microsoft#23743 without breaking.
anthonykim1
added a commit
to anthonykim1/vscode-python
that referenced
this pull request
Sep 13, 2024
Resolves: microsoft#23743 It seems that when people have a multi line string such surrounded by """ quotes, the white spacing inside the quote is very much intentional, and so if we detect that they are in such code-block, we would rather not normalize/truncate the white spaces for that specific code block.
anthonykim1
added a commit
to anthonykim1/vscode-python
that referenced
this pull request
Sep 13, 2024
…24096) Reverts microsoft#23977 Have to revert microsoft#23977 with issue: microsoft#23743 due to microsoft#24069 Will revisit why microsoft#23743 is breaking if contained inside other top level (in ast term) code block, and look into how to support microsoft#23743 without breaking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #23743
It seems that when people have a multi line string such surrounded by """ quotes, the white spacing inside the quote is very much intentional, and so if we detect that they are in such code-block, we would rather not normalize/truncate the white spaces for that specific code block.