Skip to content

Change PYTHONSTARTUP setting name to Python.terminal.shell integration.enabled #24153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 23, 2024
Merged

Change PYTHONSTARTUP setting name to Python.terminal.shell integration.enabled #24153

merged 3 commits into from
Sep 23, 2024

Conversation

anthonykim1
Copy link

@anthonykim1 anthonykim1 commented Sep 23, 2024 •
edited
Loading

Resolves: #24143
/cc @cwebster-99 @Tyriar

@anthonykim1 anthonykim1 self-assigned this Sep 23, 2024
@anthonykim1 anthonykim1 added feature-request Request for new features or functionality area-terminal area-repl skip package*.json package.json and package-lock.json don't both need updating labels Sep 23, 2024
@anthonykim1 anthonykim1 marked this pull request as ready for review September 23, 2024 18:26
@vs-code-engineering vs-code-engineering bot added this to the September 2024 milestone Sep 23, 2024
Tyriar
Tyriar requested changes Sep 23, 2024
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just suggested setting description change

@anthonykim1 @Tyriar
Update package.nls.json
c96fb3d 
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
@anthonykim1 anthonykim1 requested a review from Tyriar September 23, 2024 18:40
@anthonykim1 anthonykim1 enabled auto-merge (squash) September 23, 2024 18:43
@anthonykim1 anthonykim1 merged commit f8b861a into microsoft:main Sep 23, 2024
40 checks passed
@anthonykim1 anthonykim1 mentioned this pull request Sep 24, 2024
Merged
anthonykim1 added a commit that referenced this pull request Sep 24, 2024
@anthonykim1
Adjust PythonStartUp test for new setting value (#24165)
d879a0d 
Since setting name is changed:
#24153
Adjusting the test accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@anthonykim1 anthonykim1

Labels
area-repl area-terminal feature-request Request for new features or functionality skip package*.json package.json and package-lock.json don't both need updating
Projects
None yet
Milestone
September 2024
Development

Successfully merging this pull request may close these issues.

Consider a different setting name for shell integration settings
2 participants
@anthonykim1 @Tyriar