Skip to content

Conversation

eleanorjboyd
Copy link
Member

@eleanorjboyd eleanorjboyd commented Sep 24, 2024

Removing branch coverage from the payload as the initial way it was being discovered / added was not documented / in the coverage.py API and therefore is not guaranteed to be stable. Removing for now with plans to add upstream and re-include in the extension here

coverage PR: #24118

@eleanorjboyd eleanorjboyd added bug Issue identified by VS Code Team member as probable bug area-testing labels Sep 24, 2024
@eleanorjboyd eleanorjboyd self-assigned this Sep 24, 2024
@vs-code-engineering vs-code-engineering bot added this to the September 2024 milestone Sep 24, 2024
@eleanorjboyd
Copy link
Member Author

eleanorjboyd commented Sep 25, 2024

this PR also includes a fix where the detail coverage map uses uri.fspath as the key in the resultResolver for consistency:
this.detailedCoverageMap.set(uri.fsPath, detailedCoverageArray);

and added logging

@eleanorjboyd eleanorjboyd merged commit 710d3c8 into microsoft:main Sep 25, 2024
40 checks passed
@eleanorjboyd eleanorjboyd deleted the retail-boar branch September 25, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-testing bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants