Skip to content

Add Github action to ensure PR's have an associated issue #24616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 17, 2024
Merged

Add Github action to ensure PR's have an associated issue #24616

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cef985d
Add Github action to ensure PR's have an associated issue
eleanorjboyd Dec 16, 2024
51341d5
update regex
eleanorjboyd Dec 16, 2024
b39ca7d
logging
eleanorjboyd Dec 16, 2024
785293c
add support for link
eleanorjboyd Dec 17, 2024
645bfcb
remove log
eleanorjboyd Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .github/workflows/pr-file-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,9 @@ name: PR files
on:
pull_request:
types:
# On by default if you specify no types.
- 'opened'
- 'reopened'
- 'synchronize'
# For `skip-label` only.
- 'labeled'
- 'unlabeled'

Expand Down Expand Up @@ -42,3 +40,15 @@ jobs:
.github/test_plan.md
skip-label: 'skip tests'
failure-message: 'TypeScript code was edited without also editing a ${file-pattern} file; see the Testing page in our wiki on testing guidelines (the ${skip-label} label can be used to pass this check)'

- name: 'Ensure PR has an associated issue'
uses: actions/github-script@v6
with:
script: |
const labels = context.payload.pull_request.labels.map(label => label.name);
if (!labels.includes('skip-issue-check')) {
const issueLink = context.payload.pull_request.body.match(/https:\/\/github\.com\/\S+\/issues\/\d+/);
if (!issueLink) {
core.setFailed('No associated issue found in the PR description.');
}
}
Loading