Skip to content

switch to use eslint.config.mjs #24882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

switch to use eslint.config.mjs #24882

merged 1 commit into from
Mar 7, 2025

Conversation

eleanorjboyd
Copy link
Member

@eleanorjboyd eleanorjboyd commented Mar 7, 2025 •
edited
Loading

  • add eslint.config.mjs (copied over eslintignore into the file as well)
  • fixed package.json script due to deprecation of --ext
  • few small linting issues arose as a result which I just added eslint ignores by hand

@eleanorjboyd eleanorjboyd added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. skip tests Updates to tests unnecessary skip-issue-check skip package*.json package.json and package-lock.json don't both need updating labels Mar 7, 2025
@eleanorjboyd eleanorjboyd marked this pull request as ready for review March 7, 2025 19:21
@eleanorjboyd eleanorjboyd requested review from karthiknadig and anthonykim1 and removed request for karthiknadig March 7, 2025 19:22
@vs-code-engineering VS Code Engineering
Copy link

⚠️ This PR originates from a fork. Due to security restrictions, pipelines from forks are no longer triggered automatically. Learn more.

If the changes appear safe, you can manually trigger the pipeline by commenting /AzurePipelines run.

@vs-code-engineering vs-code-engineering bot added this to the March 2025 milestone Mar 7, 2025
@eleanorjboyd eleanorjboyd changed the title simple eslint update- by parts switch to use eslint.config.mjs as config file Mar 7, 2025
@eleanorjboyd eleanorjboyd changed the title switch to use eslint.config.mjs as config file switch to use eslint.config.mjs\ Mar 7, 2025
@eleanorjboyd eleanorjboyd changed the title switch to use eslint.config.mjs\ switch to use eslint.config.mjs Mar 7, 2025
@eleanorjboyd eleanorjboyd merged commit 0c4a30d into microsoft:main Mar 7, 2025
50 of 54 checks passed
@eleanorjboyd eleanorjboyd deleted the great-turkey branch March 7, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

@anthonykim1 anthonykim1 Awaiting requested review from anthonykim1

Assignees

@eleanorjboyd eleanorjboyd

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. skip package*.json package.json and package-lock.json don't both need updating skip tests Updates to tests unnecessary skip-issue-check
Projects
None yet
Milestone
March 2025
Development

Successfully merging this pull request may close these issues.
2 participants
@eleanorjboyd @karthiknadig