Allow Activated Virtual Envs to Be Detected w/ a Workspace File #25141
Conversation
|
Looks like there are two UTs failing that I will look at. |
|
I removed the test because it was just verifying the condition I also removed. I considered inverting the test, but that seemed sub-optimal since you could have a limitless number of "test XYZ works when ABC is true" where ABC is many different things. However, I'm happy to add the test back in and change it if that's prefered. I'm also working with my company to get the CLA approval. |
|
@microsoft-github-policy-service agree company="OpenAI" |
|
Hi! Sorry for the delay on this. Wondering if you have tried our new python environments extension and if you want the same given that extension? If so we can port over the changes to something similar on that extension since that extension will handle environment related tasks moving forward |
|
Thanks for the PR @tgrue-openai This looks good, the original comment and code from #20526 didn't make sense for me either, since opening multi-root workspace should be allowed when there is |
Addresses #25140 (which I just filed).
Of note, I'm not sure if the existing
traceVerbose('VS Code was not launched from the command line');is correct.As far as I can tell, workspaceFile != multiroot workspaces. I'm not sure why this check previously existed. I don't know if this might cause others problems; but right now this check causes a lot of challenge for our workflow.