Skip to content

Fix auto test discovery to respect setting changes without reload #25261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2025

Conversation

Copilot
Copy link

@Copilot Copilot AI commented Jul 8, 2025

Modified the event handler to check both the setting and the pattern before triggering test discovery:

This ensures that when users disable the setting, test discovery immediately stops running on file saves without requiring a VS Code reload.

Fixes #24117.

Co-authored-by: eleanorjboyd <26030610+eleanorjboyd@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] Check auto refresh setting during pytest discovery Fix auto test discovery to respect setting changes without reload Jul 8, 2025
@Copilot Copilot AI requested a review from eleanorjboyd July 8, 2025 20:48
Copilot finished work on behalf of eleanorjboyd July 8, 2025 20:48
@eleanorjboyd eleanorjboyd added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. skip tests Updates to tests unnecessary labels Jul 8, 2025
@eleanorjboyd eleanorjboyd marked this pull request as ready for review July 8, 2025 22:27
@vs-code-engineering vs-code-engineering bot added this to the July 2025 milestone Jul 8, 2025
@eleanorjboyd eleanorjboyd merged commit 58bd7b6 into main Jul 9, 2025
87 of 89 checks passed
@eleanorjboyd eleanorjboyd deleted the copilot/fix-24117 branch July 9, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. skip tests Updates to tests unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check auto refresh setting during pytest discovery
4 participants