Return early in activate from env var collection #25286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the changes appear safe, you can manually trigger the pipeline by commenting |
|
Env contribution now: We won't be contributing path and ps1 from Python extension when env extension is installed, hich seems like what has been causing the issue for all. Image is pre-PR |
Co-authored-by: Eleanor Boyd <26030610+eleanorjboyd@users.noreply.github.com>
eleanorjboyd
approved these changes
Jul 14, 2025
eleanorjboyd
added a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Jul 21, 2025
Resolves: microsoft#25275 microsoft#25284 It seems like python env var experiment is interfering when env extension is being used. We should not implicit activate with env var experiment if environment extension is installed and being used. --------- Co-authored-by: Eleanor Boyd <26030610+eleanorjboyd@users.noreply.github.com>
eleanorjboyd
added a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Jul 21, 2025
Resolves: microsoft#25275 microsoft#25284 It seems like python env var experiment is interfering when env extension is being used. We should not implicit activate with env var experiment if environment extension is installed and being used. --------- Co-authored-by: Eleanor Boyd <26030610+eleanorjboyd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #25275 #25284
It seems like python env var experiment is interfering when env extension is being used.
We should not implicit activate with env var experiment if environment extension is installed and being used.