remove pylance create,start,stop. Pylance will now do that itself. #25370
+542
−1,235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschnurr
commented
Aug 8, 2025
| new LanguageClient(PYTHON_LANGUAGE, 'Python Language Server', args[0], args[1]), | ||
| start: (client: BaseLanguageClient): Promise<void> => client.start(), | ||
| stop: (client: BaseLanguageClient): Promise<void> => client.stop(), | ||
| getTelemetryReporter: () => reporter, |
There was a problem hiding this comment.
keeping getTelemetryReporter() removing others
bschnurr
commented
Aug 8, 2025
| const api = pylanceExtension.exports; | ||
| if (api.client && api.client.isEnabled()) { | ||
| pylanceApi = api; | ||
| await api.client.start(); |
There was a problem hiding this comment.
just removing this call to start. not sure why the diff is messed up. My other idea was to leave this logic in. but change pylance's api.client.isEnabled() to return false and then just return in that case.
bschnurr
commented
Aug 8, 2025
| @@ -255,7 +255,7 @@ export namespace InterpreterQuickPickList { | |||
| } | |||
|
|
|||
| export namespace OutputChannelNames { | |||
| export const languageServer = l10n.t('Python Language Server'); | |||
| export const JediLanguageServer = l10n.t('Jedi'); | |||
There was a problem hiding this comment.
renamed Jedi's output window to 'Jedi'
bschnurr
commented
Aug 8, 2025
| @@ -62,6 +64,7 @@ export class JediLSExtensionManager implements IDisposable, ILanguageServerExten | |||
| this.serverManager.dispose(); | |||
| this.serverProxy.dispose(); | |||
| this.analysisOptions.dispose(); | |||
| this.outputChannel.dispose(); | |||
There was a problem hiding this comment.
now dispose Jedi's output channel here instead of the global one
bschnurr
commented
Aug 8, 2025
| }, | ||
| start: (client: BaseLanguageClient): Promise<void> => client.start(), | ||
| stop: (client: BaseLanguageClient): Promise<void> => client.stop(), | ||
| getTelemetryReporter: () => getTelemetryReporter(), |
There was a problem hiding this comment.
diff is messed up, removing createClient, start, stop
bschnurr
commented
Aug 8, 2025
| createClient(...args: any[]): BaseLanguageClient; | ||
| start(client: BaseLanguageClient): Promise<void>; | ||
| stop(client: BaseLanguageClient): Promise<void>; | ||
| getTelemetryReporter(): TelemetryReporter; |
There was a problem hiding this comment.
removing
createClient(...args: any[]): BaseLanguageClient;
start(client: BaseLanguageClient): Promise<void>;
stop(client: BaseLanguageClient): Promise<void>;
…vscode-python into remove-pylance-client2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this means older of versions of pylance wont work.