Skip to content

Post request with empty body, now working fine. #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 3, 2019
Merged

Post request with empty body, now working fine. #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
32daeb8
Post request with empty body, now working fine.
krototype Sep 16, 2019
eed1515
Merge branch 'dev' into abhsriva/emptyPostRequest
krototype Sep 16, 2019
6850658
updated the tests for this case
krototype Sep 16, 2019
f7c333b
Merge branch 'abhsriva/emptyPostRequest' of https://github.com/micros…
krototype Sep 17, 2019
2ebf666
made change to use undefined instead of null as classname
krototype Sep 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion spec/core/GraphRequestUtil.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,15 @@ describe("GraphRequestUtil.ts", () => {
node2.link = node1;
try {
serializeContent(node1);
throw new Error("Something wrong with the serialize content, it should stringify cyclic referenced objects");
throw new Error("Something wrong with the serialize content, it should not stringify cyclic referenced objects");
} catch (error) {
assert.equal(error.message, "Unable to stringify the content");
}
});

it("Should return undefined for the case of undefined content value", () => {
const val = undefined;
assert.equal(serializeContent(val), undefined);
});
});
});
2 changes: 1 addition & 1 deletion src/GraphRequestUtil.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export const urlJoin = (urlSegments: string[]): string => {
*/

export const serializeContent = (content: any): any => {
const className: string = content.constructor.name;
const className: string = content === undefined ? undefined : content.constructor.name;
if (className === "Buffer" || className === "Blob" || className === "File" || className === "FormData" || typeof content === "string") {
return content;
}
Expand Down