Skip to content

fix casing on filename example variable #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 9, 2019
Merged

fix casing on filename example variable #255

merged 3 commits into from
Dec 9, 2019

Conversation

gidsg
Copy link
Contributor

@gidsg gidsg commented Nov 29, 2019 •
edited
Loading

Summary

Fix typo in code example. Variable is declared as filename but referenced as fileName

Motivation

FIx code example

Test plan

N/A

Closing issues

Fixes #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

darrelmiller
darrelmiller approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@darrelmiller darrelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this.

@muthurathinam muthurathinam merged commit 4a70b05 into microsoftgraph:dev Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@darrelmiller darrelmiller darrelmiller approved these changes

@muthurathinam muthurathinam muthurathinam approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gidsg @darrelmiller @muthurathinam