You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In LargefileUploadTask, set Content-Type to application/octet-stream explicitly, otherwise application/json will be used by default, which is not correct.
Motivation
Although using the default application/json does not impact the functionality, if a client using the SDK has something like http-interceptor to examine the request payload, incorrect Content-Type can be misleading, for example, application/json suggests plain/text in json format.
Test plan
N/A
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
@nikithauc , No, files can be successfully uploaded even the header is set to application/json by default, so I guess the API server just doesn't check it. This is NOT actually impacting the file upload functionality.
However, as I mentioned, it is not uncommon, on the client-side, there is logic like http-interception doing things logs, audits, and etc. Having application/json in the header is misleading and can cause unexpected behaviours.
No unit test updated for now since the existing part of the code is not covered in any test cases. I can add some (of course need to do some refactoring to make it testable) if it is needed.
Thanks!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
LargefileUploadTask, setContent-Typetoapplication/octet-streamexplicitly, otherwiseapplication/jsonwill be used by default, which is not correct.Motivation
Although using the default
application/jsondoes not impact the functionality, if a client using the SDK has something likehttp-interceptorto examine the request payload, incorrectContent-Typecan be misleading, for example,application/jsonsuggestsplain/textinjsonformat.Test plan
N/A
Types of changes
Checklist