Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double equals doesn't work between single brackets #37

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Double equals doesn't work between single brackets #37

merged 1 commit into from
Jul 29, 2021

Conversation

nelsontkq
Copy link

the POSIX standard doesn't require == to work between single brackets, this only works in bash. This change should fix the touchbar failing to reinitialize after suspend.

Double equals doesn't work between single brackets
4f56a72 
the POSIX standard doesn't require == to work between single brackets, this only works in bash. This change should fix the touchbar failing to reinitialize after suspend.
@mikeeq
Copy link
Owner

mikeeq commented Jul 29, 2021

True, thanks for catching that up. I'm not using suspend, that's the reason why I haven't caught that up earlier, Thanks again!

➜ shellcheck suspend/rmmod_tb.sh                   

In suspend/rmmod_tb.sh line 2:
if [ "${1}" == "pre" ]; then
            ^-- SC3014: In POSIX sh, == in place of = is undefined.


In suspend/rmmod_tb.sh line 4:
elif [ "${1}" == "post" ]; then
              ^-- SC3014: In POSIX sh, == in place of = is undefined.

For more information:
  https://www.shellcheck.net/wiki/SC3014 -- In POSIX sh, == in place of = is ...

@mikeeq mikeeq merged commit 1cab25d into mikeeq:f34 Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsontkq @mikeeq