mediaProperty: check access #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 3, 2014 14:43
Throw exception if it's not possible and we can't return any value.
|
"PropertyMap" : I would have named it "PropertiesMap", because there may be several properties, is'nt it ? |
|
I was not sure of the name in fact... But a lot of name (containers, folders...) in avTranscoder are singular. Here the function getPropertiesAsMap indicates that there are several properties. |
added 2 commits
December 3, 2014 20:15
This type is not only used for metadatas, so the new name avoid confusion.
16abf4f to
6f0532f
Compare
valnoel
added a commit
that referenced
this pull request
Dec 3, 2014
MediaProperty: check access and rename DataMap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.