Transcoder: call init method to process #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchampet
commented
Dec 3, 2014
- Add private methods to simplify Transcoder::process method.
- Transcoder: set FFmpeg log level to QUIET by default.
added 6 commits
December 3, 2014 15:54
* No need to expect the user to call init() before process(). * Note: the init() method can be called several times with no side effects. * Update pyTest.
In order to simplify process method.
* Clean indentation. * Avoid while( 1 ). * Suppress warning of getTotalDurationFromProcessMethod: add default case in switch.
Can call setProcessMethod before adding the streams.
* Remove comment. * No need to call init().
* Set it to AV_LOG_QUIET in Transcoder constructor. * Set it to AV_LOG_DEBUG if setVerbose of Transcoder to true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.