unix new-lines in headers possible #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
|
It was yesterday on some github api requests, closing headers by "\n" . Unable to reproduce today, maybe some temporary bug. Anyway, cURL recognizes it as header and sends $line into closure, causing setting empty header in array and issuing E_NOTICE "Undefined index 1" . It's matter of opinion if silently ignore invalid headers or issue E_USER_NOTICE or exception. "Undefined index 1" is neither of them. |
milo
added a commit
that referenced
this pull request
Feb 8, 2015
|
I think it was due to long header splitted on multiple lines (f8dc2d4). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"\n" caused E_NOTICE with undefined offset 1