Skip to content

Figures & other stylistic updates #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 26, 2018
Merged

Figures & other stylistic updates #58

merged 4 commits into from
Mar 26, 2018

Conversation

miykael
Copy link
Owner

@miykael miykael commented Mar 25, 2018

As discussed in #55, I've added output figures and log files (except some of the very long workflow log streas) to gh-pages (ec74660).

While doing so, I've also updated the requested kernel version (set to [default]) and changed some stylistic things.

I've also switched the order of the "solution" and the "exercise/answer" cell, so that the # write your solution here" cell appears before the actual solution, just like here.

@djarecka
Copy link
Collaborator

@miykael - do you want to test all notebooks with both pythons? I just decided to test only with python 3, since we're trying to move to py3, but we can probably start testing both.

I'm trying to rebuild the tests. I sometimes have also timeout. I believe didn't figure out which extra parameter should have to be changed to be safe.

@miykael
Copy link
Owner Author

miykael commented Mar 26, 2018

@djarecka - testing all notebooks with both pythons would be a good idea, but that would mean we would need an additional conda environment in the docker image (i.e. creating another 1.8GB of volume), no?

How would you change the kernel in the notebook images? Replacing the specification at the end of the notebook might work.

@djarecka
Copy link
Collaborator

I think we would just have to build the second dockerfile. I would also strongly suggest people to use py3 only (that's why I'm not completely sure if we want to use default python and add additional tests)

@miykael
Copy link
Owner Author

miykael commented Mar 26, 2018

I'm also for suggesting people to use py3. But I'm recommending to leave default. Because in the docker image, default is python3. If I'm not mistaken, it should be the neuro environment.

Now, we could also specify that it should use the neuro or an py3 environment. But this would mean, anybody who opens the notebook locally on their machine (without docker), will get a kernel error, that py3 or neuro wasn't found. This error shouldn't happen with default.

Therefore I propose to leave default in. But we could also rename neuro to py3 to make it clear for user that they should use python 3. What do you think?

@miykael miykael merged commit 80cb519 into master Mar 26, 2018
@djarecka
Copy link
Collaborator

Oh, I see what you mean. Sure, we can use default but I think that at the same time we can keep official docker images with py3 only, so we don't "create" a new Nipype users that use py2 instead of py3. Some people will want to use py2 anyway, but there are people that simple don't know which python they should choose when they're starting, so having a py3 as a default option might help in the future IMO.

don't have any opinion regarding env name

@miykael
Copy link
Owner Author

miykael commented Mar 26, 2018

Ok, than we leave it at default. And yes, I think it's best to move everybody slowly to py3.

And for the people that want to use py2, there's always the option to create a new docker image that is based on the tutorial, with the additional conda environment in it. I did something similar for my last workshop.

@miykael miykael deleted the figures branch April 11, 2018 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants