-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken 'Edit on GitHub' link #1321
Comments
Thanks for the report. It appears that the problem presents itself if you are missing a closing slash at the end of the repo_url. Add the closing slash and it should work correctly: repo_url: https://github.com/opensciencegrid/docs/ I'm just guessing, but it could be that the added support for fragment and query string based schemes was confused by the lack of a closing slash and messed things up. In any event, it appears that we only tested with the slash, not without. After all, MkDocs own config includes the slash and the example in the documentation shows a slash. I'm undecided if the closing slash should be a requirement. Although, apparently, it previously worked fine without it, so requiring it would be a regression for some users. |
Does that mean the |
This is unique to
In the first two examples, the |
I looked at the tests and realized that we were missing a test. We have a test were We were also missing a test for |
Also broke up `edit_uri` tests into individual methods and added a few missing senarious. Fixes mkdocs#1321.
Also broke up `edit_uri` tests into individual methods and added a few missing senarious. Fixes #1321.
My apologies for commenting on a closed issue. In my setup, mkdocs lives in a subdirectory of the repo. This setup break edit links because it assumes the docs directory is in the root while it is not. |
Then you will need to manually set the |
Wonderful! |
We recently updated to 0.17.0 and it seems to have broken our 'Edit on GitHub' link, you can see this in action here. The link given is https://github.com/edit/master/docs/index.md when it should be https://github.com/opensciencegrid/docs/edit/master/docs/index.md. repo_url appears to be set properly.
The text was updated successfully, but these errors were encountered: