Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer titles of pages based on full Markdown parsing #3191

Merged
merged 9 commits into from
May 29, 2023
Merged

Infer titles of pages based on full Markdown parsing #3191

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2fbc8c4
Infer titles of pages based on full Markdown parsing
oprypin Apr 21, 2023
92d0520
Add test for stripping attribute list
oprypin Apr 21, 2023
659b36f
Add test for setext style heading
oprypin Apr 21, 2023
0cb382c
Simplify tests to not use real files
oprypin Apr 23, 2023
85d0eea
Strip anchorlinks from titles
oprypin Apr 23, 2023
cc4e4c2
Preserve legacy behavior only for edge cases in plugins
oprypin Apr 23, 2023
61b82c3
Remove some redundancy
oprypin Apr 28, 2023
a852237
Merge remote-tracking branch 'origin/master' into htitle
oprypin May 29, 2023
22b294d
Fixup
oprypin May 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove some redundancy
  • Loading branch information
@oprypin
oprypin committed Apr 28, 2023
commit 61b82c3c1bfd1290c230d708930375d9b8d5fa6f
7 changes: 3 additions & 4 deletions mkdocs/structure/pages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import logging
import os
import posixpath
import warnings
from typing import TYPE_CHECKING, Any, Callable, Mapping, MutableMapping, Optional, Union
from urllib.parse import unquote as urlunquote
from urllib.parse import urljoin, urlsplit, urlunsplit
Expand Down Expand Up @@ -232,10 +233,8 @@ def read_source(self, config: MkDocsConfig) -> None:
self.markdown, self.meta = meta.get_data(source)

def _set_title(self) -> None:
"""Soft-deprecated, do not use."""
self.render(
{'markdown_extensions': (), 'mdx_configs': None}, # type: ignore
Files([]),
warnings.warn(
"_set_title is no longer used in MkDocs and will be removed soon.", DeprecationWarning
)

@weak_property
Expand Down