Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lerna and cssnext #89

Merged
merged 16 commits into from
Aug 31, 2017
Merged

Use lerna and cssnext #89

merged 16 commits into from
Aug 31, 2017

Conversation

xcatliu
Copy link
Member

@xcatliu xcatliu commented Aug 31, 2017

No description provided.

@cht8687
Copy link
Member

cht8687 commented Aug 31, 2017

Travis failed:
$ rake
rake aborted!
No Rakefile found (looking for: rakefile, Rakefile, rakefile.rb, Rakefile.rb)

@xcatliu

@xcatliu
Copy link
Member Author

xcatliu commented Aug 31, 2017

@cht8687 Please ignore this. The new version doesn't require ruby or sass anymore.

README.md Outdated

### Scalable

Plugin system makes css scalable. You can import plugins to enhance Mobi.css, or use the plugin as a standalone css library. **It's even possible to use a plugin without Mobi.css**.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really minor => css need to be capital letter in readme: CSS.
(I checked Bootstrap, Foundation... they all use capital letter CSS 😄 )

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@xcatliu
Copy link
Member Author

xcatliu commented Aug 31, 2017

@cht8687 Fixed travis issue.

"postcss-import": "^10.0.0",
"rimraf": "^2.6.1",
"stylelint": "^8.0.0",
"stylelint-config-standard": "^17.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing author, repo, license info which a npm install will generate warnings.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks!

@xcatliu xcatliu merged commit b35ef60 into master Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants