Remove strict validation on response_modes_supported member of OAuthMetadata
#1243
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thMetadata` (modelcontextprotocol#1242) Allows compatibility with servers that support the JWT Secured Authorization response mode per https://openid.net/specs/oauth-v2-jarm.html#name-authorization-server-metada
response_modes_supported member of OAuthMetadata (#1242)response_modes_supported member of OAuthMetadata
panargirakis
reviewed
Aug 6, 2025
|
Yes, I realise that by default Keycloak also adds jwt.query, jwt.fragment... |
ochafik
approved these changes
Aug 7, 2025
There was a problem hiding this comment.
Looks good, thanks for sending this change!
(the OAuth 2.0 Multiple Response Type Encoding Practices linked from the response_mode_supported in rfc8414 indeed meant for this to be an open list of modes: Note that it is expected that additional Response Modes may be defined by other specifications in the future)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows compatibility with servers that support the JWT Secured Authorization response mode per https://openid.net/specs/oauth-v2-jarm.html#name-authorization-server-metada
Resolves #1242
Motivation and Context
Fixes OAuth flow when using Keycloak (or any auth server that supports JARM)
How Has This Been Tested?
Tested using remote OAuth2.0 flow with FastMCP and Keycloak
Breaking Changes
None
Types of changes
Checklist
Additional context
None