Skip to content

Consistent casing for default headers Accept and Content-Type #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 12, 2025
Merged

Consistent casing for default headers Accept and Content-Type #1263

merged 2 commits into from
Aug 12, 2025
+1 −1

Conversation

glinf
Copy link
Contributor

@glinf glinf commented Aug 12, 2025 •
edited
Loading

Motivation and Context

  • Accept uses pascal casing
  • content-type uses lowercase

Aligning `Accept to also use lowercase.

How Has This Been Tested?

uv run pytest

Breaking Changes

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

N/A

@glinf glinf changed the title Consitent casing for default headers Accept and Content-Type Consistent casing for default headers Accept and Content-Type Aug 12, 2025
@glinf glinf force-pushed the glinf/consistent-casing-for-default-headers branch from d3fb896 to 0b695a6 Compare August 12, 2025 09:39
@glinf glinf marked this pull request as ready for review August 12, 2025 09:45
@glinf glinf requested a review from a team as a code owner August 12, 2025 09:45
@glinf glinf requested a review from ochafik August 12, 2025 09:45
@Kludex
Copy link
Member

Kludex commented Aug 12, 2025

Please fix accept instead.

@glinf
Copy link
Contributor Author

glinf commented Aug 12, 2025

@Kludex updated

@Kludex Kludex merged commit a82c69b into modelcontextprotocol:main Aug 12, 2025
10 checks passed
@Kludex
Copy link
Member

Kludex commented Aug 12, 2025

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

@ochafik ochafik Awaiting requested review from ochafik ochafik is a code owner automatically assigned from modelcontextprotocol/python-sdk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glinf @Kludex