-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix: enables context injection into resources #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fubuloubu
wants to merge
6
commits into
modelcontextprotocol:main
Choose a base branch
from
fubuloubu:fix/resources-with-context
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: enables context injection into resources #413
fubuloubu
wants to merge
6
commits into
modelcontextprotocol:main
from
fubuloubu:fix/resources-with-context
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
29732d5
to
7a3ea56
Compare
7a3ea56
to
c78d1ac
Compare
3 tasks
context injection into prompts would be great also |
It would be fantastic with this feature! Since most of my endpoints use context, I currently have to wrap them all as tools. |
4445683
to
0790305
Compare
This PR doesn't seem to be enough. We can't read from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebase of #248 (copied below)
closes #244
Motivation and Context
According to the readme it should be possible to pass a
Context
to a resource (like it is for tools), but that's currently throwing an error (#244)How Has This Been Tested?
How Has This Been Tested?
Added tests, and confirmed with inspector that the below demo server works as intended:
Breaking Changes
Types of changes
Checklist
Additional context
I tried to follow a similar structure to the way context is injected in tools