Fix sse_client timeout setting not works in post_writer #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thank you for your contribution to fix the timeout issue in the post_writer function. This is indeed a valid issue that needs addressing.
However, I'm closing this PR as a duplicate of PR #340, which addresses the same issue with a more complete solution by applying both the general timeout and read timeout parameters. PR #340 has already been assigned to the r-05-25 milestone and will be included in an upcoming release.
We appreciate your efforts to improve the MCP Python SDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently timeout setting in sse_client are not works in post_writer function when it post a request to the server, which may cause some tool calls to raise a timeout error.
Motivation and Context
Make some time consuming tool call works.
How Has This Been Tested?
When i connect to a SSE MCP server and try to call a tool which usually takes 20 seconds to respond, it always failed.
Error in post_writer:meta=None content=[TextContent(type='text', text='Error executing request: Post "https://xxxxxxx": context canceled', annotations=None)] isError=FalseAfter pass the timeout from sse_client into the httpx post request, developers can take control as they need.
And this change solves my issue, tested in my case.
Breaking Changes
Nothing changes but make it works correctly.
Types of changes
Checklist
Additional context