Fix hanging on streams when stdio_client exiting #559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Triggers a TaskGroup cancel after reaching the finally code block.
ihrpr
requested changes
Apr 30, 2025
Merged to test_stdio.py
|
You're welcome, @ihrpr. Just so you know, all requested changes are resolved :) |
ihrpr
requested changes
May 8, 2025
Use async versions of .close() Co-authored-by: ihrpr <inna.hrpr@gmail.com>
|
@ihrpr Resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggers a TaskGroup cancel after reaching the finally code block.
Motivation and Context
stdin_writerin the task group hangs when pressing Ctrl+c.Now we explicitly close the streams blocking.
How Has This Been Tested?
Tested in a new simple no-op test and a real Uvicorn Starlette application.
Types of changes
Checklist