Skip to content

Fix SSE client failing when server not running on root #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix SSE client failing when server not running on root #564

wants to merge 1 commit into from

Conversation

michaelpoluektov
Copy link

Fix #563

mcp-shadow[bot]
mcp-shadow bot reviewed May 13, 2025
View reviewed changes
Copy link

@mcp-shadow mcp-shadow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue identified in PR #564 has already been resolved with a more comprehensive fix in PR #659 (merged on May 12, 2025). The solution is to handle path resolution on the server side using ASGI's built-in root_path mechanism, rather than implementing a client-side workaround.

@mcp-shadow mcp-shadow bot closed this May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcp-shadow mcp-shadow[bot] mcp-shadow[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sse_client fails if URL is not on the root path
1 participant
@michaelpoluektov