Fix handle sse disconnect event to free read_stream_writers[session_id] #582
Conversation
|
This looks better. Can you add a test case, please? |
I added . Please check |
| @@ -120,9 +120,19 @@ async def sse_writer(): | |||
| } | |||
| ) | |||
|
|
|||
| async def handle_see_disconnect(message: Message) -> None: | |||
There was a problem hiding this comment.
this is also handled in #586. let's review that one first and then we can review this one as we have a test here -- thank you for adding it
There was a problem hiding this comment.
I left my thought here And I don't think add callback to connect_sse is proper
There was a problem hiding this comment.
-
Unfortunately we can't upgrade starlette now.
-
Some of the fixes are already covered by Handle SSE Disconnects Properly #612
| ] | ||
|
|
||
| [[package]] | ||
| name = "starlette" | ||
| version = "0.27.0" | ||
| version = "0.41.3" |
There was a problem hiding this comment.
Unfortunately we can't upgrade starlette version now
| async def handle_sse(request): | ||
| async with sse.connect_sse( | ||
| request.scope, request.receive, request._send | ||
| ) as streams: | ||
| await app.run( | ||
| streams[0], streams[1], app.create_initialization_options() | ||
| ) | ||
| return Response("MCP SSE") |
There was a problem hiding this comment.
I believe this was already fixed by #612
Motivation and Context
When SSE Connection disconnect , we should free the
_read_stream_writersHow Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context