-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Auth SSE simple example #610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a quick look over this - and had claude look at it (here).
I think this is good for demo purposes. I'll give it a try before approving the bigger one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I tested with the inspector, and a github app I had around, and works.
I separated out the confused deputy fix in a follow up since it's going to require some SDK changes that I don't want to block this on:
#648
Adding a simple example for auth which was implemented in #255
This tiny server is useful:
Tested with Inspector
