Fix the issue of get Authorization header fails during bearer auth #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihrpr
requested changes
May 6, 2025
Comment on lines
37
to
39
| auth_header = conn.headers.get("Authorization") or conn.headers.get( | ||
| "authorization" | ||
| ) |
There was a problem hiding this comment.
Suggested change
| auth_header = conn.headers.get("Authorization") or conn.headers.get( | |
| "authorization" | |
| ) | |
| auth_header = next( | |
| (conn.headers.get(key) for key in conn.headers if key.lower() == "authorization"), | |
| None | |
| ) |
| auth_header = conn.headers.get("Authorization") | ||
| auth_header = conn.headers.get("Authorization") or conn.headers.get( | ||
| "authorization" | ||
| ) | ||
| if not auth_header or not auth_header.startswith("Bearer "): |
There was a problem hiding this comment.
would Bearer have the same issue?
|
@ihrpr thanks for your suggestion. all of the above have been updated.Please review them again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bearer auth retrieves the Authorization from the headers, but the HTTPConnection.headers uses lowercase authorization, resulting in authentication failure.