fix(win32): ensure proper termination of child processes #658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor process termination logic to handle both parent and child processes - Increase timeout for graceful termination from 1s to 2s - Consolidate process termination functions to avoid zombie processes - Add proper type hints for process list handling This change ensures that all child processes are properly terminated when killing a parent process on Windows, preventing zombie processes from being left behind.
|
This seems straightforward to me, but I do not consider myself qualified to review a win32 PR. |
|
@dsp-ant @cristipufu @jspahrsummers @samuelcolvin require code review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that all child processes are properly terminated when killing a parent process on Windows, preventing zombie processes from being left behind.
This change ensures that all child processes are properly terminated when killing a parent process on Windows, preventing zombie processes from being left behind.
Motivation and Context
On Windows, when terminating a parent process, child processes can become orphaned and turn into zombie processes if not properly handled. This change implements a more robust process termination mechanism that ensures both parent and child processes are properly cleaned up.
How Has This Been Tested?
Tested process termination with various scenarios:
Single process termination
Parent process with multiple child processes
Processes with nested child processes
Verified that no zombie processes remain after termination
Tested both graceful termination and force kill scenarios
Breaking Changes
No breaking changes. This is a bug fix that improves existing functionality without changing the API or behavior from the user's perspective.
Types of changes
Checklist
Additional context