Move Prompt
object instantiation from server to prompt manager
#687
+45
−33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Prompt()
decorator inserver.py
is instantiating a Prompt object before adding it to the list of prompts. This is inconsistent with how theTool()
decorator works; it delegates tool instantiation to the tool manager.Motivation and Context
To make the decorators consistent and create clear separation of concerns: I have moved prompt object instantiation from
server.py
toprompts/manager.py
.How Has This Been Tested?
I updated and ran all unit tests.
Breaking Changes
No. Users will not be impacted as the
prompt()
decorator's signature remains unchanged.Types of changes
Checklist
Additional context
Separation of concerns: instantiation and managements of prompt objects should be done by the prompt manager, not the server.