Add progress notification callback for client #721
Merged
+609
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerome3o-anthropic
previously approved these changes
May 15, 2025
| @@ -231,15 +243,25 @@ async def send_request( | |||
| ](1) | |||
| self._response_streams[request_id] = response_stream | |||
|
|
|||
| # Set up progress token if progress callback is provided | |||
| request_data = request.model_dump(by_alias=True, mode="json", exclude_none=True) | |||
There was a problem hiding this comment.
[properly non-blocking] wondering if we can set this in the pydantic model before dumping? I'm really not fussed either way (it would just give you validation etc)
| # Connect to the server with callbacks | ||
| async with sse_client(everything_server_url + "/sse") as streams: | ||
| # Set up message handler to capture notifications | ||
| async def message_handler(message): |
There was a problem hiding this comment.
[non-blocking] I was thinking we could literally tap the memory channels that wireup the transport, but this is also good
There was a problem hiding this comment.
I just wanted to make sure that the transports also support all the features, especially after catching an issues with sampling in shttp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It started as adding Everything server test for StreamableHttp and SSE, but then I noticed I can't test progress notifications.
This PR adds a callback for progress notifications to the client session and sets progress token to request id where there is a callback. This approach is similar to how we are handling it in TypeScript.
Adds Everything server with tools, resources and prompts.