Win32 fixes #723
Draft
Win32 fixes #723
+1,124
−901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
Refactored test to utilize `stdio_client` for more accurate simulation of the fixed behavior and added handling for proper initialization with `ClientSession`. Increased timeout to 10 seconds to prevent premature failures and ensured hanging issue is properly caught and reported. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
…ptions Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
…d exceptions Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
Separated the stdio client logic into dedicated modules for transport and parameter handling. The refactoring reduces complexity by isolating process management into `StdioClientTransport` and moving environment defaulting to a `parameters` module, improving maintainability and readability. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
Updated the Windows-specific test to use `@pytest.mark.parametrize` for varied command arguments. This change improves test coverage and simplifies the testing of process creation scenarios. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
Separated the stdio client logic into dedicated modules for transport and parameter handling. The refactoring reduces complexity by isolating process management into `StdioClientTransport` and moving environment defaulting to a `parameters` module, improving maintainability and readability. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
Commented out the stdout reader task initialization to prevent its execution. This change will temporarily avoid potential issues related to the stdout reader while other components continue functioning as expected. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context