-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Feature/617 async call tools #866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
davemssavage
wants to merge
33
commits into
modelcontextprotocol:main
Choose a base branch
from
davemssavage:feature/617-async-call-tools
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feature/617 async call tools #866
davemssavage
wants to merge
33
commits into
modelcontextprotocol:main
from
davemssavage:feature/617-async-call-tools
+1,311
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s naming params consistently
9 tasks
…test logic for higher level session join test (currently skipped due to subtle bug in test)
…, avoid unnecessary dependencies
…ise scenarios where memory cache may not be sufficient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress towards Async Call Tools support as per modelcontextprotocol/modelcontextprotocol#617
Motivation and Context
To see if the protocol as defined in modelcontextprotocol/modelcontextprotocol#617 is implementable in practice, if so provide a reference implementation for others to follow
How Has This Been Tested?
Unit testing only at this stage
Breaking Changes
None planned, goal is to make this backwards compatible and opt-in
Types of changes
Checklist
Additional context
This patch is shared for discussion at this stage, it will be marked as draft. As noted in RequestCache class there are several TODOs of varying degrees of severity that need resolving before it should be considered for merge