Skip to content

relax validation #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

dr3s
Copy link

@dr3s dr3s commented Jun 3, 2025

  • fixed broken tests on main due to async handling
  • Relax auth validation to permit additional responses in list fields
  • Correct token_type and normalize to align with spec

Fixes #814

Motivation and Context

The validation prevented usage with 3rd party Oauth AS. The pydantic models are both used for validating hosted Oauth endpoints and validating responses from 3rd party AS.

How Has This Been Tested?

tested the simple auth client example against a remote MCP server with a 3rd party AS

Breaking Changes

n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@dr3s dr3s marked this pull request as ready for review June 3, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OAuthMetadata as define is too restrivtive, hence produces a ValidationError
2 participants