Skip to content

Upgrade local node version to v20.10.0 #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bibek-stripe
Copy link

Motivation and Context

Updates the locally required node version to v20.10.0 because there are many dependencies in the project on Node features in v20 and above. For example, Running npm run test on a fresh install currently fails with many errors including URL.canParse is not a function (the method was added in v19.9)

How Has This Been Tested?

npm run test now passes on fresh install of the repo

Breaking Changes

No breaking changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@bibek-stripe bibek-stripe changed the title Set node version Upgrade local node version to v20.10.0 Apr 7, 2025
Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this! In engines we can update to use 18.17.0 which would have the fix but yet support older version of Node

@@ -12,7 +12,7 @@
"url": "git+https://github.com/modelcontextprotocol/typescript-sdk.git"
},
"engines": {
"node": ">=18"
"node": ">=20.10.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"node": ">=20.10.0"
"node": ">=18.17.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants