Skip to content

chore: fix typo #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: fix typo #315

wants to merge 2 commits into from

Conversation

Skn0tt
Copy link

@Skn0tt Skn0tt commented Apr 11, 2025

Fixes small typo from #247.

Pizzaface pushed a commit to RewstApp/mcp-inspector that referenced this pull request May 2, 2025
* Remove bin folder, leaving cli, server, and client
* This fixes modelcontextprotocol#315
* In .gitignore,
  - add .idea
  - remove bin/build
* Remove bin and bin/cli.js
* Remove bin/scripts/copy-cli.js
* Refactor/move bin/scripts to cli/scripts
* Refactor/move bin/src/index.ts to cli/src/cli.ts
* Refactor/renamed client/bin/cli.js to client/bin/client.js
* In .github/workflows/main.yml,
  - add run of cli tests
* In cli/pacakge.json
  - change main and bin/mcp-inspector-cli properties to build/cli.js
* In client/package.json,
  - change bin/mcp-inspector-client properties to build/start.js
* In pacakge.json
  - change bin/mcp-inspector property to ./cli/build/cli.js
  - removed bin and cli/bin from files list
  - removed @modelcontextprotocol/inspector-bin dependency
  - rearranged and corrected scripts
@mdarveau
Copy link

mdarveau commented May 6, 2025

I think it should be { permission: z.enum(["write", "admin"])},

@Skn0tt
Copy link
Author

Skn0tt commented May 6, 2025

I agree!

@Skn0tt
Copy link
Author

Skn0tt commented May 6, 2025

cc @geelen @jspahrsummers

@geelen
Copy link
Contributor

geelen commented May 7, 2025

Ha, that's my mistake. I don't have approve/merge permissions so will let Justin hit the button. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants