Skip to content

fix: Forwarding EventSource headers to requests to reuse EventSource… #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xuzhongpeng
Copy link

fix: Forwarding EventSource headers to requests to reuse EventSource's Last-Event-ID, solving the session ID reuse problem during reconnection.

Motivation and Context

The current MCP protocol in SSE mode does not yet support reconnection with sessionId. If we forward the last-event-id created by EventSource, and the SSE server delivers the sessionId as the SSE id, the client can leverage EventSource's last-event-id mechanism during reconnection to resume a connection with the same sessionId instead of issuing a new sessionId.

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

…'s Last-Event-ID, solving the session ID reuse problem during reconnection.
Pizzaface pushed a commit to RewstApp/mcp-inspector that referenced this pull request May 2, 2025
…able-endpoint

Fix support for streamable-http connections
Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Sorry about the delay in reviewing PRs. This PR will require a merge with main, and tests need to be added to cover the functionality and prevent regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants