Import Buffer from node:buffer explicitly
#349
Conversation
3fa9f5a to
7dd336c
Compare
Buffer from node:bufferexplicitlyBuffer from node:buffer explicitly
7dd336c to
2ea8cf7
Compare
2ea8cf7 to
36c9f74
Compare
|
I tested this with Deno and it worked. |
| @@ -1,3 +1,4 @@ | |||
| import type { Buffer } from "node:buffer"; | |||
There was a problem hiding this comment.
probably because it's only used as type in https://github.com/lacolaco/mcp-typescript-sdk/blob/import-node-buffer/src/server/stdio.ts#L27
There was a problem hiding this comment.
Exactly. In this file Buffer is referred only as an argument type.
There was a problem hiding this comment.
it's also used directly. this._readBuffer.append(chunk)
How its been tested?
There was a problem hiding this comment.
That ReadBuffer you mention is imported from shared/stdio.js, which is modified to use node:buffer.
What this Issue is concerned with and resolves is a direct reference to the global variable Buffer. It is fine if the object of type Buffer is derived from node:buffer.
There was a problem hiding this comment.
is there a way to add a test to prevent regressions?
Import
Bufferfromnode:bufferexplicitly to get deno-compatibility.Motivation and Context
How Has This Been Tested?
npm run buildandnpm testBreaking Changes
No
Types of changes
Checklist
Additional context