fix: add windows env PROGRAMFILES, avoid some exe can not be found #386
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixweinberger
approved these changes
Jun 27, 2025
There was a problem hiding this comment.
Seems uncontroversial to me and only affects Windows in any case.
PROGRAMFILES points to the Program Files folder e.g. C:\Program Files according to Microsoft docs: https://learn.microsoft.com/en-us/windows/deployment/usmt/usmt-recognized-environment-variables
Making this available by default in the environment seems sensible if it makes setup of common libraries like puppeteer easier - which according to the link shared it does.
|
@muzea thank you for submitting this PR! The change looks good to me, kicking off CI now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add windows env PROGRAMFILES, avoid some exe can not be found.
Motivation and Context
Some libs, such as puppeteer, use env PROGRAMFILES in Windows.
Adding default environment variable settings can make it easier to configure mcp based on these libs.
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context