Skip to content

Add stderr access before start #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025
Merged

Conversation

hmwildermuth
Copy link
Contributor

Currently, when using StdioClientTransport with stderr set to "pipe", the stderr stream is not available until after start() is called. This means that any error output from the child process during startup is lost if the caller wants to capture it.

Motivation and Context

The current implementation has a race condition:

  1. User creates StdioClientTransport with stderr: "pipe"
  2. User wants to attach stderr listeners
  3. But stderr is only available after start() is called
  4. By the time start() is called and stderr becomes available, early error output may have already been lost

This forces users to implement workarounds like:

let stderrOutput = '';
const transport = new StdioClientTransport({...});
const connectionPromise = client.connect(transport);
transport?.stderr?.on('data', (chunk) => {
  stderrOutput += chunk.toString();
});
await connectionPromise;

How Has This Been Tested?

The changes maintain backward compatibility while fixing the race condition. No existing behavior is changed - we just make the stderr stream available earlier.

Breaking Changes

No, purely additive

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Would be great to have a test for this as well

@ihrpr ihrpr merged commit 7079818 into modelcontextprotocol:main May 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants