optimization: When using custom SSE request,Authorization
header can still be automatically attached to the SSE request.
#478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the custom SSE request, the
Authorization
header can still be automatically attached to the SSE request.Motivation and Context
Current:
When user customizes the initial SSE request, it will prevent an
Authorization
header from being automatically attached to the SSE request. It require user to fetch tokens fromauthProvider
and set theAuthorization
header manually.Ref:
typescript-sdk/src/client/sse.ts
Lines 36 to 44 in bced33d
Goal:
Simplify the code and reduce the risk of misuse.
There is an misused case: CherryHQ/cherry-studio#5709
How Has This Been Tested?
npm test -- src/client/sse.test.ts -t "refreshes expired token during SSE connection"
Breaking Changes
Types of changes
Checklist
Additional context