Skip to content

fix: Ensure _meta object is not lost when onprogress option is passed #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025

Conversation

daidi
Copy link
Contributor

@daidi daidi commented May 29, 2025

When the onprogress option is passed, the _meta object in the request params was being overwritten, causing any existing _meta content to be lost.

Motivation and Context

this is right,the _meta could be passed to the svr

client?.callTool({
        name: toolName,
        arguments: input as Record<string, unknown>,
        _meta: {
          __test: 'test',
        },
      }, CallToolResultSchema, {}})

however:

client?.callTool({
        name: toolName,
        arguments: input as Record<string, unknown>,
        _meta: {
          __test: 'test',
        },
      }, CallToolResultSchema, {

onprogress: (progress: any) => {
}
}})

_meta disappeared...

How Has This Been Tested?

yes

Breaking Changes

no

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

When the onprogress option is passed, the _meta object in the request
params was being overwritten, causing any existing _meta content to be lost.
Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

Added tests and fixed build issue

@ihrpr ihrpr merged commit b2b426f into modelcontextprotocol:main May 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants