feat: add controlled client-side logging that respects NODE_ENV #665
+55
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add logging utility that suppresses output when NODE_ENV=production - Replace all console usage in client code with logger - Add ESLint no-console rule for client code (except logging.ts) This prevents unwanted console output in production environments like Claude Code while still allowing debugging in development.
ihrpr
requested changes
Jun 19, 2025
There was a problem hiding this comment.
thank you @ashwin-ant! I think we can safely remove those logs, we should not be doing console log at all in SDK (unless it's an example file and logs serve the depo purpose)
let me know if you want me to remove them!
ashwin-ant
added a commit
that referenced
this pull request
Jun 20, 2025
- Remove all console.log, console.warn, and console.error from src/client and src/server - Add ESLint no-console rule for client and server directories (excluding tests) - Keep console statements in test files, examples, and CLI tools as intended Addresses feedback in PR #665 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
9 tasks
ashwin-ant
added a commit
that referenced
this pull request
Jun 20, 2025
- Remove all console.log, console.warn, and console.error from src/client and src/server - Add ESLint no-console rule for client and server directories (excluding tests) - Keep console statements in test files, examples, and CLI tools as intended Addresses feedback in PR #665 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #615
Motivation and Context
This prevents unwanted console output in production environments like Claude Code while still allowing debugging in development. Otherwise the
console.warnappears in the terminal output.How Has This Been Tested?
Tested locally against Claude Code build
Breaking Changes
Types of changes
Checklist
Additional context