fix: add type safety for tool output schemas in ToolCallback #670
+54
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3f68c37 to
08808a4
Compare
bhosmer-ant
reviewed
Jun 27, 2025
There was a problem hiding this comment.
@sushichan044 many thanks for doing this! One minor suggestion inline for the server example.
| @@ -43,7 +43,7 @@ server.registerTool( | |||
| void country; | |||
| // Simulate weather API call | |||
| const temp_c = Math.round((Math.random() * 35 - 5) * 10) / 10; | |||
| const conditions = ["sunny", "cloudy", "rainy", "stormy", "snowy"][Math.floor(Math.random() * 5)]; | |||
| const conditions = ["sunny", "cloudy", "rainy", "stormy", "snowy"][Math.floor(Math.random() * 5)] as unknown as "sunny" | "cloudy" | "rainy" | "stormy" | "snowy"; | |||
There was a problem hiding this comment.
Suggested change
| const conditions = ["sunny", "cloudy", "rainy", "stormy", "snowy"][Math.floor(Math.random() * 5)] as unknown as "sunny" | "cloudy" | "rainy" | "stormy" | "snowy"; | |
| const weatherConditions = ["sunny", "cloudy", "rainy", "stormy", "snowy"] as const; | |
| const conditions = weatherConditions[Math.floor(Math.random() * 5)]; |
There was a problem hiding this comment.
@bhosmer-ant yes, that's more concise 🙏
fixed: fb303d7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Enhances
ToolCallbackto support type-safe structured outputsby introducing a second generic parameter for the output schema.
fixes: #669
How Has This Been Tested?
Passing all existing tests.
No need for adding new tests as no change for runtime behavior.
Breaking Changes
None.
Types of changes
Checklist
Additional context